Re: Resources patch
| From: | Andrei Zmievski | Date: | Fri, 20 Oct 2000 13:40:29 +0000 |
| Subject: | Re: Resources patch | ||
| References: | 1 2 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-35653@lists.php.net to get a copy of this message | ||
On Fri, 20 Oct 2000, Zeev Suraski wrote:
> Well, it's not a good idea to change the API of
> register_list_destructors(). That's why I introduced
> register_list_destructors_ex(). The advantages of this approach:
> 1. No downwards incompatibility.
> 2. The new destructor types are more extensible - they're sent a pointer
> to the rsrc_list_entry structure, instead of just the resource pointer. If
> we want to add more information to this entry in the future - we can do
> that without breaking the API.
>
> I never got around to actually changing register_list_destructors() calls
> to register_list_destructors_ex() calls, but it should work fine.
Ok, so we should change the desctructor functions in all modules to
accept zend_rsrc_list_entry instead. I suppose it's safe to just destroy
the *ptr in that structure without worrying about the refcount or valid
flag?
-Andrei
A room without books is like a body without a soul.
-- Marcus Tullius Cicero (106-43 B.C.)