Re: cvs: php4 /ext/sockets php_sockets.h sockets.c

On Mon, 23 Oct 2000, Andi Gutmans wrote: > Chris, > > Can you please answer the Email I sent you when you get to it? (I'm aware I did receive it -- just didn't have the chance to reply to it when I got up. > you might not have read it yet). We really don't want read()'s behavior to > change according to the php.ini. We try to keep these kind of INI > directives as a minimum in the PHP project. > Think of it this way. Say you are using two PHP packages, Phorum and > Phplib. Each one was coded with a different INI setting for read(). If you > wanna run both on the same web site you have a problem. So either make this > two distinct functions or pass a flag to it. It's behavior should not > depend on the INI file. I understand the comment -- and made changes appropriately locally to use a 4th parameter for choosing such behavior so it behaves consistently. I'll commit the patch as soon as I make sure it works as I expect it to.. Chris