Compile Warning in ftp.c
| From: | Ignacio Vazquez-Abrams | Date: | Mon, 30 Oct 2000 18:39:01 +0000 |
| Subject: | Compile Warning in ftp.c | ||
| Groups: | php.dev | ||
| Request: | Send a blank email to php-dev+get-36479@lists.php.net to get a copy of this message | ||
I decided to be "nosy" and logged the PHP build/compile process. I found a
small problem:
1) In ext/ftp:
ftp.c: In function `ftp_genlist':
ftp.c:1207: warning: `or' of unmatched not-equal tests is always 1
Oops. This looks related to the OS/390 fix (Bug #6730) a little bit back.
--- php-4.0.4_20001027/ext/ftp/ftp.c.orig Mon Oct 30 13:34:17 2000
+++ php-4.0.4_20001027/ext/ftp/ftp.c Mon Oct 30 13:34:29 2000
@@ -1204,7 +1204,7 @@
fclose(tmpfp);
- if (!ftp_getresp(ftp) || ftp->resp != 226 || ftp->resp != 250) {
+ if (!ftp_getresp(ftp) || (ftp->resp != 226 && ftp->resp != 250)) {
free(ret);
return NULL;
}
--
Ignacio Vazquez-Abrams <ignacio@openservices.net>