Fix missed for Bug #7216: ftp_mkdir returns nothing

Jani, I sent an explination and fix to the list quite awhile ago, could you take a look at this -Jason ----- Original Message ----- From: "Jason" <jason@inetgurus.net> To: <php-dev@lists.php.net> Cc: <steve@plastrik.com>; <askalski@chek.com> Sent: Sunday, October 15, 2000 10:21 AM Subject: [PHP-DEV] RE:[PHP-DEV] PHP 4.0 Bug #7216: ftp_mkdir returns nothing - fix > This problem is cuased by Solaris's ftp server which does _not_ print > the directory after a successful MKD. According to RFC, anything with > response 257 should be good, but to comply with the style of ftp.c I > just added a condition specific to a successful solaris ftp server > return code. There should be a better way to implement this, else there > is a possibility for this to break on another non-compliant ftp server > out there. > > -Jason > > *** ftp.c.orig Sun Oct 15 12:37:41 2000 > --- ftp.c Sun Oct 15 12:47:35 2000 > *************** > *** 378,385 **** > return NULL; > > /* copy out the dir from response */ > ! if ((mkd = strchr(ftp->inbuf, '"')) == NULL) > ! return NULL; > end = strrchr(++mkd, '"'); > *end = 0; > mkd = strdup(mkd); > --- 378,390 ---- > return NULL; > > /* copy out the dir from response */ > ! if ((mkd = strchr(ftp->inbuf, '"')) == NULL) { > ! if (strstr(ftp->inbuf,"successful")) { /* Solaris FTP Server > */ > ! mkd=strdup(dir); > ! return mkd; > ! } else return NULL; > ! } > ! > end = strrchr(++mkd, '"'); > *end = 0; > mkd = strdup(mkd); > > -- > PHP Development Mailing List <http://www.php.net/> > To unsubscribe, e-mail: php-dev-unsubscribe@lists.php.net > For additional commands, e-mail: php-dev-help@lists.php.net > To contact the list administrators, e-mail: php-list-admin@lists.php.net >