Re: transparent output compression patch
| From: | Jade Nicoletti | Date: | Mon, 13 Nov 2000 18:11:54 +0000 |
| Subject: | Re: transparent output compression patch | ||
| References: | 1 2 3 4 5 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-37954@lists.php.net to get a copy of this message | ||
Ok, I merge in my changes later if you want :)
A question: how do you make output compression work with the session uri
adaption?
It seems that output goes through these layers:
1. output handlers (if present)
2. php_ub_body_write_no_header with session_adapt_uri
3. sapi output function (php_header_write)
If you implement the output compression as a output handler, the compressed
output will be scanned for uris :(
Do you see the problem or did I miss something? :)
If you wan't it really clean, the uri adaption should be an output handler
too, shouldn't it?
-Jade.
On Mon, Nov 13, 2000 at 05:52:37PM +0200, Zeev Suraski wrote:
> Damn :) We'll have to merge code now. I'll first get your original code
> to work, and then you'd could merge in your changes.
>
> Zeev
>
> At 17:12 13-11-00, Jade Nicoletti wrote:
> >Here is an updated patch. Just in case... :)
> >
> >The deflate coding and the autodetection works now. I've definied some
> >constants
> >and I've put in some warning messages.
> >
> >-Jade.
> >
> >On Mon, Nov 13, 2000 at 12:32:57PM +0200, Zeev Suraski wrote:
> > > I'm working on converting your work to a output handler in zlib.c - I'll
> > > send you the diff when I'm done.
> > >
> > > Zeev
> >
> >--
> >===============================================================================
> > Jade Nicoletti Nicoletti Net Services Tel. 01 240 4774
> > Geschäftsleitung Postfach 2519 Fax 01 240 4775
> > System-Administration 8021 Zürich
> >============================================[ Weitere Infos:
> >http://nns.ch/ ]==
>
> --
> Zeev Suraski <zeev@zend.com>
> CTO, Zend Technologies Ltd. http://www.zend.com/
--
===============================================================================
Jade Nicoletti Nicoletti Net Services Tel. 01 240 4774
Geschäftsleitung Postfach 2519 Fax 01 240 4775
System-Administration 8021 Zürich
============================================[ Weitere Infos: http://nns.ch/ ]==