Re: Calling symbol table patch

At 02:47 PM 11/20/2000 -0600, Andrei Zmievski wrote:

On Mon, 20 Nov 2000, Sterling Hughes wrote: I don't think its really a good idea for a function to have access to the scope of the function that called it (and be able to modify it). That just makes me a little queasy somehow. You shouldn't be able to modify and access one functions scope from another function. The patch does not make any provisions for modification. Only accessing the value of the variables in the outer calling scope.

Ok, I happened to ignore that little zend_hash_copy call. I looked at the underlying modifications to zend (and assume you just created a zval with a pointer to the calling stacks hashtable). My original get_defined_vars() patch did that wrong, I assumed that you didn't copy the hashtable. -Sterling