Re: How do I contribute new module?
| From: | Andi Gutmans | Date: | Thu, 30 Nov 2000 17:58:29 +0000 |
| Subject: | Re: How do I contribute new module? | ||
| References: | 1 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-39718@lists.php.net to get a copy of this message | ||
Yes, I agree.
Also in your MINIT function le_muscat (the muscat resource ID) should be a true global and not use the thread-safe global macros (check out MINIT of php_mysql.c or another module which uses resources).
Besides that it looks OK. I don't know the C API of Muskat and how it works so I can't really comment on the module itself.
I think having something which will help people create indexes would be useful.
Andi
At 18:37 30/11/00 +0100, Sterling Hughes wrote:
As a preliminary note I think the api should be changed to muscat_* purpose to conform to the naming guidelines of PHP. -Sterling--- Andi Gutmans <andi@zend.com> http://www.zend.com/Muscat is a search engine tool; used for indexing of documents and retrieval. It ships with a html parser called dialogserver which acts on magic tags in the html to perform various actions relating to searches. For an example of muscat use, see www.webtop.com (not mine). The purpose of this module is to be able to write and customise complex search pages in php. It has two levels, access to an old C api, which is what we need immediatly, and then access to the more normal C++ API which we are currently using via a perl module.-----Original Message----- From: Andi Gutmans [mailto:andi@zend.com] Sent: Thursday, November 30, 2000 05:16 To: Sam Liddicott; php-dev@lists.php.net Subject: Re: [PHP-DEV] How do I contribute new module? What is Muscat? If people feel it's a good thing to have in the standard distribution and your code is good we will add it.OK. Enclosed is a .tgz of the module (from ext) with a sample php script which feeds some text to muscat and is returned an array of suitable search terms which could be used in a muscat database to find similar texts. Here the search terms are just printed out along with the number of times* [*weighted by other rules] they occured, but these could be fed back to a search.Do you want to send a .tar.gz of the code and a more thorough explanation (maybe with an example) so that people can take a glance.-- PHP Development Mailing List <http://www.php.net/> To unsubscribe, e-mail: php-dev-unsubscribe@lists.php.net For additional commands, e-mail: php-dev-help@lists.php.net To contact the list administrators, e-mail: php-list-admin@lists.php.netThanks, Andi At 14:47 30/11/00 +0000, Sam Liddicott wrote:I now have a php interface to the c-muscat API I would liketo contrib.I will be working on extending this interface to the C++ APIover the nextcouple of weeks. How do I "add" this module to the other php modules; and beable to updateit and such. Sam -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, e-mail: php-dev-unsubscribe@lists.php.net For additional commands, e-mail: php-dev-help@lists.php.net To contact the list administrators, e-mail:php-list-admin@lists.php.net --- Andi Gutmans <andi@zend.com> http://www.zend.com/ -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, e-mail: php-dev-unsubscribe@lists.php.net For additional commands, e-mail: php-dev-help@lists.php.net To contact the list administrators, e-mail: php-list-admin@lists.php.net