RE: [PHP-DEV] Use fsock.c from my module

> -----Original Message----- > From: Ignacio Vazquez-Abrams [mailto:ignacio@openservices.net] > Sent: Friday, December 01, 2000 05:03 > To: Sam Liddicott > Cc: php-dev@lists.php.net > Subject: Re: [PHP-DEV] Use fsock.c from my module > > > On Fri, 1 Dec 2000, Sam Liddicott wrote: > > > In order to keep my network interface portable I thought it > better to write > > using fsock.c and require that sockets be enabled for php. > > > > Is this advisable? > > This makes your code portable across operating systems, but > not across PHP > installations. IIRC, there have been plenty of cases where > sockets don't > compile correctly but aren't needed anyway; your extension > would be completely > unusable in these cases. AFAIK the right way to do > portability, unfortunately, > is to go through all the #ifdef loops. I see what you are saying. Surely all the ifdef loops have been hacked into fsock.c If fsock.c won't compile, then my code won't because it has to do what fsock.c does. Or, whatever fixes would need making to my code in order to compile it could be done to fsock to fix that? Or maybe there's lots of extra stuff in fsock I won't need? I could rip-off the whole of fsock.c and take out the bits I don't need? Which would you do? Thanks for your sage advice here. Sam