Re: Changes to ext/xml config.m4

On Tue, 09 Jan 2001, Rui Hirokawa wrote: > > Andrei, > > On Mon, 8 Jan 2001 14:36:51 -0600 > Andrei Zmievski <andrei@ispi.net> wrote: > > > Rui, > > > > I see that you have made some changes to ext/xml/config.m4 file and I > > don't think those belong in there. Specifically, you changed it to look > > for Expat installed in /usr/local and /usr - this goes contrary to > > meaning of the bundled Expat library. What I mean is that the > > --enable-xml switch (on by default) means that the bundled library > > should be used, not that Expat should be searched for wherever possible. > > If people don't want to use bundled Expat, they should do --disable-xml. > > I understand what you said. > > How about this ? > --enable-xml (on by default): use bundled expat lib. > --enable-xml2 (off by default): search libexpat>1.95 and use it. > --disable-xml : disable both options. Why not use --with-xml[=path] so that if you do --with-xml it uses bundled Expat, and you can also supply optional path to external Expat. BTW, your changes to Makefile.in broke my build - it found external Expat and used it first but the included header file made all XML function names start with php_ so there were linking problems. -Andrei * Gun manufacturers don't make bad products, bad parents do. *