PHP 4.0 Bug #9328 Updated: ext/pgsql/php_pgsql.h needs to include postgres_fe.h not postgres.h
| From: | ler at lerctr dot org | Date: | Sun, 18 Feb 2001 22:59:52 +0000 |
| Subject: | PHP 4.0 Bug #9328 Updated: ext/pgsql/php_pgsql.h needs to include postgres_fe.h not postgres.h | ||
| Groups: | php.dev | ||
| Request: | Send a blank email to php-dev+get-46861@lists.php.net to get a copy of this message | ||
ID: 9328
User Update by: ler@lerctr.org
Status: Open
Bug Type: PostgreSQL related
Description: ext/pgsql/php_pgsql.h needs to include postgres_fe.h not postgres.h
Actually, you don't need EITHER file.
Here is a new patch against 4.0.4pl1:
$ cvs diff -c -rREL_4_0_4pl1
cvs diff: Diffing .
Index: php_pgsql.h
===================================================================
RCS file: /cvsroot/php/ext/pgsql/php_pgsql.h,v
retrieving revision 1.1.1.2
diff -c -r1.1.1.2 php_pgsql.h
*** php_pgsql.h 2000/12/23 23:05:41 1.1.1.2
--- php_pgsql.h 2001/02/18 22:57:20
***************
*** 29,35 ****
#ifdef PHP_PGSQL_PRIVATE
#undef SOCKET_SIZE_TYPE
- #include <postgres.h>
#include <libpq-fe.h>
#ifdef PHP_WIN32
--- 29,34 ----
$
Previous Comments:
---------------------------------------------------------------------------
[2001-02-18 17:37:21] ler@lerctr.org
Starting with PostgreSQL 7.1beta5 (or current CVS), PHP's pgsql
extension needs to only include <postgres_fe.h> to compile.
Here is a patch:
Index: php_pgsql.h
===================================================================
RCS file: /cvsroot/php/ext/pgsql/php_pgsql.h,v
retrieving revision 1.1.1.2
diff -c -r1.1.1.2 php_pgsql.h
*** php_pgsql.h 2000/12/23 23:05:41 1.1.1.2
--- php_pgsql.h 2001/02/18 21:15:45
***************
*** 29,35 ****
#ifdef PHP_PGSQL_PRIVATE
#undef SOCKET_SIZE_TYPE
! #include <postgres.h>
#include <libpq-fe.h>
#ifdef PHP_WIN32
--- 29,35 ----
#ifdef PHP_PGSQL_PRIVATE
#undef SOCKET_SIZE_TYPE
! #include <postgres_fe.h>
#include <libpq-fe.h>
#ifdef PHP_WIN32
--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 972-414-9812 E-Mail: ler@lerctr.org
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749
$
---------------------------------------------------------------------------
Full Bug description available at: http://bugs.php.net/?id=9328