Re: NSAPI patch / CVS access
| From: | Andi Gutmans | Date: | Fri, 02 Mar 2001 16:49:03 +0000 |
| Subject: | Re: NSAPI patch / CVS access | ||
| References: | 1 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-47811@lists.php.net to get a copy of this message | ||
At 10:29 AM 3/2/2001 -0600, Andrew Johnson wrote:
Andi Gutmans wrote:
I just reviewed the patch quickly. Are you sure that using MALLOC() for the
SG(request_info) variables is OK?
I think so. php4_execute() contains
nsapi_request_ctor(NSLS_C SLS_CC);
retval = nsapi_module_main(NSLS_C SLS_CC);
nsapi_request_dtor(NSLS_C SLS_CC);
where the _ctor routine does the MALLOC()s and _dtor the FREE()s.
OK I just wanted to make sure that you guys checked this.
(Appologies for my last unnecessary email Andi, I usually work through my email serially...).Happens to me all the time :) Andi