RE: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/odbc php_odbc.c

>Actually might have been me doing a bad patch... but I just sent sebastian >the same fix to give a try. if that works, excellent :) I think it was my mistake. The '&' was in my working version, but not in the patch I sent. Anyway, do you know of a way to do a diff with the file currently in CVS? So, I make the modification in the checked-out tree, test it, if it works I want to create a diff with the original version and mail it to php-dev... And it's not that I don't have karma for ext/odbc, I only have cvs write access for dbx. That's enough for me, but working on dbx leads to detecting some things in other database modules as well, as I recently found in the odbc and pgsql modules. I sent a patch for the pgsql as well, but that is really more a question of 'should the warning be removed' than anything else. I also found that e.g. in mysql when I fetch a row, the indexed and associative array do not point to the same data, but each has it's own copy. (eg result[0]=='x', result['fieldX]=='x', set result[0] to 'y' and result['fieldX'] still is 'x'). I worked around that in dbx, which returns true references for this kind of thing (also if it's not supported in the database module initially). Cheerio, Marc.