Bug #10070 Updated: incorrect ob_gzhandler implementation

ID: 10070 Updated by: jmoore Reported By: mnot@akamai.com Old-Status: Open Status: Closed Bug Type: Zlib Related PHP Version: 4.0 Latest CVS (29/03/2001) Assigned To: Comments: This should have been resolved with various patches that have been added recently, please test with latest CVS and reopen if this is not the case. (Although once again can we really write workarounds for every browser that breaks the standards?) - James Previous Comments: --------------------------------------------------------------------------- [2001-04-02 00:53:35] mnot@akamai.com IIRC, it advertises both, so it shouldn't be an issue. I don't have a windows box around to make sure with... --------------------------------------------------------------------------- [2001-03-30 19:45:38] avsm@php.net Just to clarify a bit more, and see if a workaround is worthwhile: Currently, if both gzip and deflate are present in the Accept-Encoding, we will prefer the gzip. The only good reason for a workaround in the code is if a widespread browser presents deflate only, and then proceeds to break. Do these broken versions of IE present Accept-Encoding: deflate _only_ ? And which versions are they? Anil --------------------------------------------------------------------------- [2001-03-30 14:59:49] sniper@php.net If a browser breaks RFCs -> not our problem. Closed. --Jani --------------------------------------------------------------------------- [2001-03-30 13:07:42] avsm@php.net Applied a patch to add Vary: headers if we add a Content-Encoding: header. Regarding the browser compatibility with Deflate, I think we should just leave it like it is. _They_ break the RFC; encourage people to upgrade to modern, non-broken browsers instead ? --------------------------------------------------------------------------- [2001-03-29 21:21:53] mnot@akamai.com ob_gzhandler doesn't appear to set a Vary: header on responses, which means that proxy caches could store a compressed version of the resource and serve it to clients which can't handle the encoding. This is very difficult to debug for Web sites, and should be fixed ASAP. For an example of the proper headers to send, see the PHP at: http://www.mnot.net/cgi_buffer/ Also, in my experience, some versions of MSIE don't handle deflate compession correctly, even though their Accept-Encoding claims they do. It might be better to avoid deflate altogether, as gzip support is pretty much the unwritten standard. Cheers, --------------------------------------------------------------------------- The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online. ATTENTION! Do NOT reply to this email! To reply, use the web interface found at http://bugs.php.net/?id=10070&edit=2