Bug #10681 Updated: Fix for #9698 breaks more than it fixes

From: Date: Wed, 09 May 2001 15:28:28 +0000
Subject: Bug #10681 Updated: Fix for #9698 breaks more than it fixes
Groups: php.dev 
Request: Send a blank email to php-dev+get-54509@lists.php.net to get a copy of this message
ID: 10681 Updated by: sniper Reported By: kettler@gmx.net Old-Status: Open Status: Critical Bug Type: Network related Operating system: PHP Version: 4.0 Latest CVS (05/05/2001) Assigned To: Comments: Someone who knows that part of PHP better should check the patch provided. Marked as to be fixed before 4.0.6 --Jani Previous Comments: --------------------------------------------------------------------------- [2001-05-06 13:10:26] kettler@gmx.net Sure. Here it is: http://global.team17.com/php4-unsigned.patch Works for both printf and sprintf. Is there another function I missed? --------------------------------------------------------------------------- [2001-05-06 12:00:05] derick@php.net Sounds ok to me, are you willing to make a patch for this? --------------------------------------------------------------------------- [2001-05-05 04:40:03] kettler@gmx.net <?php $ipaslong = ip2long("208.247.106.187"); print long2ip($ipaslong)."n"; print bin2hex(pack("N", $ipaslong))."n"; ?> That script run with PHP 4.0.5 prints: 208.247.106.187 d0f76abb whereas with the latest CVS version it prints: 127.255.255.255 7fffffff That makes that function completely unusable for me (and for others probably too). I have another proposal for fixing bug #9698, and that is implementing %u as a sprintf format specifier to output unsigned longs instead of signed. This way he could use the following script for his problem (should go onto the ip2long page then): <?php $ip = gethostbyname("www.php.net"); $out = sprintf("http://%u/<br>n", ip2long($ip)); echo $out; ?> If that fix would be accepted (and the other fix rolled back), I could add %u to sprintf myself and post it here. --------------------------------------------------------------------------- ATTENTION! Do NOT reply to this email! To reply, use the web interface found at http://bugs.php.net/?id=10681&edit=2

« previous php.dev (#54509) next »