Bug #10913: hw_who() returns incorrect data & prints extraneous string (patch incl.)

From: torben@php.net Operating system: Linux 2.2.14/Mandrake 7 PHP version: 4.0 Latest CVS (2001-05-16) PHP Bug Type: Hyperwave related Bug description: hw_who() returns incorrect data & prints extraneous string (patch incl.) Just found this with hw_who(): the returned array skipped some attributes and printed what looked like a debugging string when called. Basic upshot was that the array returned didn't have all of the actual data returned from the Hyperwave server, and all values were associated with the wrong keys (except for 'self'). This patch seems to fix it for me: Index: hw.c =================================================================== RCS file: /repository/php4/ext/hyperwave/hw.c,v retrieving revision 1.81 diff -u -r1.81 hw.c --- hw.c 2001/04/30 12:53:55 1.81 +++ hw.c 2001/05/17 01:20:09 @@ -1190,7 +1190,10 @@ ptr = object; +#if 0 php_printf("%s\n", ptr); +#endif + /* Skip first two lines, they just contain: Users in Database @@ -1228,6 +1231,9 @@ add_assoc_long(user_arr, "self", 0); ptr++; + while((*ptr != '\0') && (*ptr == ' ')) + ptr++; + name = ptr; while((*ptr != '\0') && (*ptr != ' ')) ptr++; @@ -1235,6 +1241,9 @@ add_assoc_string(user_arr, "id", name, 1); ptr++; + while((*ptr != '\0') && (*ptr == ' ')) + ptr++; + name = ptr; while((*ptr != '\0') && (*ptr != ' ')) ptr++; -- Edit Bug report at: http://bugs.php.net/?id=10913&edit=1