Re: mmap in php_passthru_fd in file.c ?
| From: | Andi Gutmans | Date: | Fri, 18 May 2001 07:24:34 +0000 |
| Subject: | Re: mmap in php_passthru_fd in file.c ? | ||
| References: | 1 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-55722@lists.php.net to get a copy of this message | ||
At 09:19 AM 5/18/2001 +0200, Jani Taskinen wrote:
And then I find the magical 'if(!issock) {' line.. :) But still I'd rather nuke mmap..HOW fast is it anyway compared to reading/writing in chunks?I think it probably isn't really faster (at least not noticeably) because we are anyway writing to network which I think is our bottleneck. Also it is not necessarily faster on all systems (it is system independent). I agree with you and think we should just nuke it from there. There is no good reason I can think of which justifies it in that code. Andi