Bug #10960: coding error in fopen_wrappers.c

From: egan@sevenkings.net Operating system: Linux PHP version: 4.0.5 PHP Bug Type: PHP options/info functions Bug description: coding error in fopen_wrappers.c From previous bug report 10322 submitted by Paul Gregg: In main/fopen_wrappers.c I see that there is a function: PHPAPI int php_check_specific_open_basedir(char *basedir, char *path PLS_DC) However "basedir" is never used in this function at all, only PG(open_basedir). Surely this negates the point of the function being > called individually for each tokenised entry on open_basedir/php.ini? --- end of bug report 10322 Although Paul was correct, "Jason Greene" <jason@php.net> marked his report as bogus, apparently because it was included as part of a larger patch which Jason claimed was plagarizing his (Jason's) earlier patch, and Jason did not notice the one-line correction dealing with the logical error. Paul's report of the logical error was not bogus, and his one-line correction was obviously correct. Here it is again: --- fopen_wrappers.c.orig Mon Feb 26 00:07:31 2001 +++ fopen_wrappers.c Fri May 18 12:40:54 2001 @@ -147,7 +147,7 @@ SLS_FETCH(); /* Special case basedir==".": Use script-directory */ - if ((strcmp(PG(open_basedir), ".") == 0) && + if ((strcmp(basedir), ".") == 0) && SG(request_info).path_translated && *SG(request_info).path_translated ) { -- Edit Bug report at: http://bugs.php.net/?id=10960&edit=1