RE: [PHP-DEV] Bug #10681 Updated: Fix for #9698 breaks more than it fixes

I shouldn't even bother sending this, but some people (read: me) might be a little put off if someone had to quote the word "fix" whenever referring to a piece of code they had written. Its a PHP limitation and had nothing to do with my code, I was just trying to address the problem at hand. > -----Original Message----- > From: derick@php.net [mailto:derick@php.net] > Sent: Saturday, May 19, 2001 8:27 PM > To: php-dev@lists.php.net > Subject: [PHP-DEV] Bug #10681 Updated: Fix for #9698 breaks > more than it > fixes > > > ID: 10681 > Updated by: derick > Reported By: kettler@gmx.net > Old-Status: Critical > Status: Closed > Bug Type: Network related > Operating system: > PHP Version: 4.0 Latest CVS (05/05/2001) > Assigned To: > Comments: > > I applied the patch, thanks for making it available. The > original 'fix' for bug #9698 has been reversed too. These > fixes will be in PHP 4.0.6. Derick > > Previous Comments: > -------------------------------------------------------------- > ------------- > > [2001-05-09 11:28:28] sniper@php.net > Someone who knows that part of PHP better should check the > patch provided. Marked as to be fixed before 4.0.6 --Jani > > -------------------------------------------------------------- > ------------- > > [2001-05-06 13:10:26] kettler@gmx.net > Sure. Here it is: > http://global.team17.com/php4-unsigned.patch Works for both > printf and sprintf. Is there another function I missed? > > -------------------------------------------------------------- > ------------- > > [2001-05-06 12:00:05] derick@php.net > Sounds ok to me, are you willing to make a patch for this? > > -------------------------------------------------------------- > ------------- > > [2001-05-05 04:40:03] kettler@gmx.net > <?php $ipaslong = ip2long("208.247.106.187"); print > long2ip($ipaslong)."n"; print bin2hex(pack("N", > $ipaslong))."n"; ?> That script run with PHP 4.0.5 prints: > 208.247.106.187 d0f76abb whereas with the latest CVS version > it prints: 127.255.255.255 7fffffff That makes that function > completely unusable for me (and for others probably too). I > have another proposal for fixing bug #9698, and that is > implementing %u as a sprintf format specifier to output > unsigned longs instead of signed. This way he could use the > following script for his problem (should go onto the ip2long > page then): <?php $ip = gethostbyname("www.php.net"); $out = > sprintf("http://%u/<br>n", ip2long($ip)); echo > $out; ?> If > that fix would be accepted (and the other fix rolled back), I > could add %u to sprintf myself and post it here. > > -------------------------------------------------------------- > ------------- > > > > ATTENTION! Do NOT reply to this email! > To reply, use the web interface found at > http://bugs.php.net/?id=10681&edit=2 > > > -- > PHP Development Mailing List <http://www.php.net/> > To unsubscribe, e-mail: php-dev-unsubscribe@lists.php.net > For additional commands, e-mail: php-dev-help@lists.php.net > To contact the list administrators, e-mail: > php-list-admin@lists.php.net > >