Re: gd/config.m4 - some issues left

Please don't forget the 4.0.6 branch when you address this. Andi At 01:45 PM 5/20/2001 +0200, Sascha Schumann wrote:

    These three lines contain the and operator (-a) which is not
    followed by an expression:

    if test "$PHP_JPEG_DIR" != "no" -a "$PHP_JPEG_DIR"; then
    if test "$PHP_PNG_DIR" != "no" -a "$PHP_PNG_DIR"; then
    if test "$PHP_XPM_DIR" != "no" -a "$PHP_XPM_DIR"; then

    I don't see the relevance of the -a ... part here.
    PHP_FOO_DIR is either no or has a usable value.

    Another issue is that png config code assumes that the user
    has enabled zlib and executes

    PHP_ADD_LIBRARY_WITH_PATH(z, $PHP_ZLIB_DIR/lib, GD_SHARED_LIBADD)

    unconditionally, even though PHP_ZLIB_DIR is set to 'no'.
    That causes a

    ./configure: no: No such file or directory

    because PHP_EXPAND_PATH will try to expand the path 'no/lib'.
    The same problem exists in pdflib's config.m4:

    checking for zlib (needed by pdflib)... checking for deflate in -lz... yes
    ./configure: no: No such file or directory

    - Sascha                                     Experience IRCG
      http://schumann.cx/                http://schumann.cx/ircg

-- PHP Development Mailing List <http://www.php.net/> To unsubscribe, e-mail: php-dev-unsubscribe@lists.php.net For additional commands, e-mail: php-dev-help@lists.php.net To contact the list administrators, e-mail: php-list-admin@lists.php.net