Re: Moving output.c from ext/standard to main/

From: Date: Fri, 20 Jul 2001 17:32:57 +0000
Subject: Re: Moving output.c from ext/standard to main/
References: 1 2  Groups: php.dev 
Request: Send a blank email to php-dev+get-60424@lists.php.net to get a copy of this message 
At 12:27 PM 7/20/2001 -0400, Jon Parise wrote:

On Fri, Jul 20, 2001 at 04:14:21PM +0300, Zeev Suraski wrote:

It's been bugging me for over a year now, and I'm now trying to figure out
the best way to do it.  output.c sits today in ext/standard, which is
wrong, as it's really a part of the inner core of PHP, and not a set of
functions.
If I move the file in the CVS repository and fix the references, then
everything would be fine, history would be retained, except checking out
old CVS's will no longer work.
If import the file into main/ and delete it from ext/standard, we lose the
history for it, which is sucky.
I'm thinking about moving the file in CVS, and in addition to fixing the
HEAD branch, fix also the 4.0.6 branch, so that we at least can check out
one version back.  What do you guys think?

I'm pretty sure the correct way to do this is:


    Copy output.c,v from ext/standard/ to main/
    'cvs remove output.c' from ext/standard/ in the HEAD branch
    Update all affected Makefile's, etc. and commit them to HEAD


That should preserve the file's history and retain compatibility
with old versions / branches.


We should do this in future too. We have renamed files in the past the *bad* way (just moving it in the cvs repository and not cp'ing it).

Andi

Thread (19 messages)

« previous php.dev (#60424) next »