Re: cvs socket extension
| From: | Chris Vandomelen | Date: | Thu, 26 Jul 2001 01:37:25 +0000 |
| Subject: | Re: cvs socket extension | ||
| References: | 1 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-61019@lists.php.net to get a copy of this message | ||
> At 20:15 24.07.2001 +0200, Markus Fischer wrote:
> >I've come up with a patch based on the ideas and suggestion that
> >came up in this thread:
> >
> >- Let the fd_set resource keep track of the highest socket; nuked
> > _select() first parameter and determine it ourself
> >- Swapped _set(), _clear() and _isset() parameters and
> > recognize plain sockets as well as array of sockets
> >
> >The patch is against current CVS and only compiled unter linux
> >(debian unstable) so far.
> >
> >Please everyone interested test and verify it and let me know
> >what you think. Due my lack of karma I can't commit it anyway,
> >feel free to do so if you find it appropriate.
>
> please let me know wether the attached patch fixes your concerns.
Looks good. But it doesn't matter if someone passes no sets into select():
if there are no sets, it essentially becomes a usleep().
Chris