Re: TSRM change

Hi Andrei! On Mon, 30 Jul 2001, Andrei Zmievski wrote: > Zeev, > > Since you've been updating TSRM stuff, I've noticed some > inconsistencies. For example, php_ldap.h says: > > # define LDAPG(v) TSRMG(ldap_globals_id, zend_ldap_globals *, v) > > But ldap_globals_id is not declared anywhere. Should it be? > It may be me, but I think it's related to TSRM: Making all in Zend make[1]: Entering directory `/usr/src/php4-200107300435/Zend' /bin/sh ../libtool --mode=compile c++ -DHAVE_CONFIG_H -I. -I. -I../main -D_REENTRANT -I../TSRM -I../TSRM -g -O2 -pthread -prefer-pic -c zend_language_scanner_cc.cc c++ -DHAVE_CONFIG_H -I. -I. -I../main -D_REENTRANT -I../TSRM -I../TSRM -g -O2 -pthread -c zend_language_scanner_cc.cc -fPIC -DPIC -o zend_language_scanner_cc.lo zend_language_scanner_cc.cc: In function `int highlight_file(char *, zend_syntax_highlighter_ini *, void ***)': zend_highlight.h:42: too few arguments to function `void zend_highlight(zend_syntax_highlighter_ini *, void ***)' zend_language_scanner_cc.cc:3138: at this point in file zend_language_scanner_cc.cc: In function `int highlight_string(zval *, zend_syntax_highlighter_ini *, char *, void ***)': zend_highlight.h:42: too few arguments to function `void zend_highlight(zend_syntax_highlighter_ini *, void ***)' zend_language_scanner_cc.cc:3162: at this point in file make[1]: *** [zend_language_scanner_cc.lo] Error 1 make[1]: Leaving directory `/usr/src/php4-200107300435/Zend' make: *** [all-recursive] Error 1 teo:/usr/src/php4-200107300435 # cat config.nice #! /bin/sh # # Created by configure './configure' \ '--with-apxs2=/usr/local/apache2/bin/apxs' \ '--enable-debug' \ '--with-xslt-sablot' \ '--with-zlib' \ '--with-dom' \ '--with-mysql=/usr/local' \ '--disable-posix' \ '--enable-trans-sid' \ '--enable-shmop' \ '--enable-sockets' \ '--enable-wddx' \ "$@" And this is because of the TSRMLS_DC (which I dunno what it is :) Shall I file a bug report of wait for more work from Zeev w/ his patch? -- teodor