Re: Re: Patch for ext/standard/[basic_functions.c|php_math.h|math.c]

Jeroen van Wolffelaar wrote: > > > I am sending this patch to the php-dev list for your > > consideration. Attached are the listing produced with > > "cvs diff -u", and listed below is a test file to > > check the changes. > > > > Basically I just added some more math funcs from the C > > library (hyperbolics and exponentials). > > Hyporbolic functions are indeed good to be added. However, > I don't think it's really need to add log2, exp10, cbrt and so > forth. It's a bit overkill, and not needed (IMO). > > the exp / pow / log functions work fine, and this is only a very > few characters less typing. cbrt is quite a WTF function, > chances are low you guess what it is, since it's not really > standard name for cubic root. And pow($x,'1/3') works fine. If we add a "log" function, does anyone want to guess how many scripts will break because of it? :-) Namespaces would have been nice now, "import log from Math;" - Stig