Re: Re: gmp_init with a base argument
| From: | Stanislav Malyshev | Date: | Thu, 02 Aug 2001 17:16:26 +0000 |
| Subject: | Re: Re: gmp_init with a base argument | ||
| References: | 1 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-61849@lists.php.net to get a copy of this message | ||
TA>> Does the lack of comments mean that I may commit the patch? (I think
TA>> that I still have CVS access.)
I was pretty busy last week, sorry, so I couldn't look at it thoroughly.
But on the quick glance your patch looks OK.
TA>> By the way:
TA>> I think that the decbin() function should bail out if you pass it a
TA>> value which contains more bits than PHP is able to handle. - Perhaps
TA>> with a hint about using GMP for large numbers.
I'd say "give a warning" istead of "bail out", but that's a good idea,
generally.
--
Stanislav Malyshev, Zend Products Engineer
stas@zend.com http://www.zend.com/ +972-3-6139665 ext.115