CVS update: php3/functions

Date: Monday May 31, 1999 @ 10:54 Author: thies Update of /repository/php3/functions In directory php:/tmp/cvs-serv3135 Modified Files: oracle.c Log Message: revert to previous behaviour. we have a problem here, 'cause our parent resource might already be freed! the same problem exists in unified_odbc (sent earlier to the list) Index: php3/functions/oracle.c diff -u php3/functions/oracle.c:1.106 php3/functions/oracle.c:1.107 --- php3/functions/oracle.c:1.106 Sat May 29 06:12:49 1999 +++ php3/functions/oracle.c Mon May 31 10:54:18 1999 @@ -258,12 +258,16 @@ efree(cur->columns); cur->columns = NULL; } +#if 0 if (cur->open){ oraConnection *db_conn; int alive = 0, type; /* 1st check if our connection is still there */ + /* XXX THIS CODE DOESN'T WORK, we need to keep track of closed connections somehow ourself + unified_odbs calls hash_apply, which is wrong as well! + */ db_conn = (oraConnection *)php3_list_do_find(ORACLE_GLOBAL(php3_oracle_module).list,cur->conn_id, &type); if (db_conn && (type == ORACLE_GLOBAL(php3_oracle_module).le_conn)) { alive = 1; @@ -282,6 +286,13 @@ cur->open = 0; } +#else + /* XXX THIS IS WRONG, MAY CAUSE PROBLEMS (closing a cursor that belongs to a closed connection) !!! */ + if (cur->open){ + oclose(&cur->cda); + } +#endif + efree(cur); } -- PHP Development Mailing List http://www.php.net/ To unsubscribe send an empty message to php-dev-unsubscribe@lists.php.net For help: php-dev-help@lists.php.net