Re: Bug #1476: multiple common of `le_uploads'

On Mon, May 31, 1999 at 04:02:11PM -0000, pumuckel@metropolis.de wrote: > From: pumuckel@metropolis.de > Operating system: Linux 2.2.9 i686 > PHP version: 3.0.8 > PHP Bug Type: Compile Warning > Bug description: multiple common of `le_uploads' > > Linking PHP3 library module into apache 1.3.6 source results in following (php3 dedicated) > warning: > > modules/php3/libphp3.a(post.o): warning: multiple common of`le_uploads' > modules/php3/libphp3.a(mime.o): warning: previous common is here > > As you can see in both files there is the variable 'le_uploads' defined, but not as > 'static'. So this variable would be available twice in the source, which is very bad > especially if on a other place this variable is defined as beeing 'extern'. > functions/post.c is the culprit. It was added with the PUT support. Declaring it as extern should be enough. -- Regards, Sascha Schumann Consultant

Index: post.c =================================================================== RCS file: /repository/php3/functions/post.c,v retrieving revision 1.120 diff -u -r1.120 post.c --- post.c 1999/05/16 12:22:36 1.120 +++ post.c 1999/05/31 16:14:41 @@ -42,7 +42,7 @@ #ifndef THREAD_SAFE int php3_track_vars; -int le_uploads; +extern int le_uploads; extern HashTable list; #endif