Re: Re: Output Compression Issues

On 16 Aug 2001 21:37:11 +0300, Zeev Suraski wrote: > At 21:27 16-08-01, Thies C. Arntzen wrote: > >On 16 Aug 2001 15:26:09 +0300, Zeev Suraski wrote: > > > - Output compression should probably check that the content type is > > text/*, > > > and not perform compression otherwise > > > >that means adding another sapi call - but i think it would make sense. > > Yep. > > > > - We can look into sending the content length header from the output > > > compression callback > > > >if ithe output is not send as chunks we should do so - the original code > >for that (10 lines) was added by me and taken out by you a few days > >later when you added the chunking support. > > Ah, good point. That's exactly what I meant if somebody can think about > good reasons not to do it :) > > Chunking is quite important, and there's no way we can know in advance how > many bytes we're going to end up having. Unless we add in another output > buffer. as i said, if we know that we didn't chunk any output before we can set the cl-header - and we should. if we have chunked output we cannot set the header and so we shouln't set the header;-) tc