Re: Branching ext/standard?

From: Date: Wed, 22 Aug 2001 21:06:53 +0000
Subject: Re: Branching ext/standard?
References: 1 2  Groups: php.dev 
Request: Send a blank email to php-dev+get-64110@lists.php.net to get a copy of this message
At 00:03 23-08-01, Jeroen van Wolffelaar wrote:
Simply committing at once with: "rewrite everything that has to do with rand" won't be any useful. 80% of the diff is the moving of code, and only 20% the real change. You also don't see what changed. Just as bad as mixing WS fixes with real fixes.
I don't think you would get too many comments if you commit to a branch either. What I would do in your case is: (a) Tag the relevant files as they are today (i.e., PRE_RAND_REDESIGN or whatever) (b) Commit your move-around changes (c) Commit the real changes (can be done immediately after (b), as long as it's separate) (d) Cross your fingers :) If we like it, the tree will be fixed quite quickly. If we don't, we can revert easily. I usually don't encourage people to commit changes that break the tree, but as we're not anywhere near a new release (that is, 4.0.7 already branched) having the tree broken for a few hours or even a couple of days under the 'less-mainstream' configurations is not a complete disaster... Zeev

Thread (12 messages)

« previous php.dev (#64110) next »