Re: wddx serialize segmentation faults fixs.
| From: | Andrey Zmievski | Date: | Fri, 04 Jun 1999 15:50:37 +0000 |
| Subject: | Re: wddx serialize segmentation faults fixs. | ||
| References: | 1 2 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-6544@lists.php.net to get a copy of this message | ||
Jim Winstead wrote:
> I don't want to sound like I'm picking on you at all, your
> patch for the problem is appreciated, especially since nobody
> else seems to be maintaining that code, but those flaws preclude
> me from commiting the patch to the repository.
I was the one who wrote the code in wddx_a.c. I've heard people talking
about segfaults when using it, but nobody has provided a reproducible example
and I don't have purify or something like that to check it. I still believe
it might be better to check the packet_len calculations and use that instead
of allocation memory inside the loop.
-Andrey
* George Orwell was an optimist. *