RE: [PHP-DEV] CVS update: php3/functions
| From: | Colin Viebrock | Date: | Tue, 08 Jun 1999 15:35:10 +0000 |
| Subject: | RE: [PHP-DEV] CVS update: php3/functions | ||
| References: | 1 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-6718@lists.php.net to get a copy of this message | ||
> > Well, now that you've changed the docs ... I gotta change the code back!
>
> Whoa. I think we should return a value between 1 and 366. That's what
> date does, at least the GNU version that's on my machine. Wouldn't it be
> better if we try to conform to a semi-standard? Or do other date utilities
> do different things?
I personally think so too. That's why I asked everyone else for their
opinions, and then took the consensus and changed the code to match what the
docs have been saying all along.
The fact that no one noticed or complained or filed a bug report about the
indiscrepency, probably shows that it's not a feature a lot of people are
using, so I didn't think we'd be to amiss in changing the code and
(technically
speaking) making the next release "backwards incompatible".
However, we would then be consistent with GNU date, some other versions, the
original documentation, and just common-sense (IMHO). January first is day
1
of the year, not day 0.
I really think this should be switched back to return 1-366. But, until
we can *all* agree on something, I'm not going to touch it.
Ah, the joys of CVS. ;)
- Colin