Re: Re: RC3

On Wed, Oct 03, 2001 at 11:24:08PM -0700, Rasmus Lerdorf wrote: > Ok, I have merged it and tested it on one of my servers. Didn't break Thanks. Now I see your commit and the 4.0.7 branch, maybe I made some silly mistake or the cvsweb page for ldap.c was cached or something. > anything. But where exactly is the ldap_result_entry freed? I am > guessing that it is actually the same memory as ldap_result points to and > when we free ldap_result there is no need to free the nested > ldap_result_entry? Is this true for nsldap as well? > > Seems logical though. Yes, that is my conclusion. I got crashes with OpenLDAP libs when first freeing individual entries and next freeing the entire result. There could be differences between libs but I suspect it is common to not copy result_entries out of the result. For now I would rather see leaks with some libs than crashes with OpenLDAP libs. If there are differences I'll try to make it better for 4.0.8. Thanks Rasmus, Stig