Re: 4.0.7 when?

Edin Kadribasic wrote: > > > >IMHO the only really critical bug is #13616. I cannot really test the RC > > >since the application that I use the most (SquirrelMail for example) do > not > > >work. > > > > This bug is really problematic, because effectively, it's not a bug. > Prior > > to the current CVS, PHP behaved pretty inconsistently with function > > redefinitions. This caused all sorts of issues, as can be seen in bug > > 9884. Sometime since 4.0.6, I changed the behavior to be consistent - if > a > > function is redefined during compile-time, it will complain, period. > > Unfortunately, this obviously has a negative side effect, and a fairly big > > one, too. Code that used to work, > > if ($foo) { > > return; > > } > > ...function definitions... > > > > no longer works. Instead, you have to do something like: > > > > if (!$foo): > > ...function definitions... > > endif; > > > > Fixing this is trivial, it means reverting the fix for bug 9884. The > > question is whether we do that or not, and we need to decide about it... > > The next PHP release is going to be 4.1.0 and is already breaking > compatibility in several ways. If it makes the language more consistent, we > should IMHO keep at as it is and document this particular change in release > notes explaining how to fix the code. The fix is simple and it should work > with previous versions of PHP. I agree. The proper fix would be to use (include|require)_once anyway. - Stig