Re: Forcing trans_sid on?

On Wed, 17 Oct 2001, Rasmus Lerdorf wrote: > This code in session.c looks odd to me: > > if (!PS(use_cookies) && send_cookie) { > PS(apply_trans_sid) = 1; > send_cookie = 0; > } > > Basically what this says is that if session.use_cookies is off, trans_sid > will be automatically used regardless of the session.use_trans_sid > setting. This doesn't make sense to me. If I specially turn off > use_cookies and trans_sid in my php.ini file because I want to control > things using my own <?=SID?> tags trans_sid getting forced on screws me > over because it will add a second PHPSESSION=..... to every link. It > won't break my app, since multiply-defining the session id is ok, but it > sure makes my urls ugly. > > What was the logic behind forcing trans_sid on in that case instead of > using the current trans_sid setting? This was not how it was originally, I'm assuming this happened when Zeev introduced the session rewrite... I've commited a fix to cvs, i'll MTB, if no one objects... -Sterling > > -Rasmus > > >