Bug #13961 Updated: some characters in incomonig variable names are silently changed
ID: 13961
Updated by: derick
Reported By: lampa@fee.vutbr.cz
Old Status: Open
Status: Assigned
Old Bug Type: Documentation problem
Bug Type: Apache related
Operating System: FreeBSD
PHP Version: 4.0.6
Old Assigned To:
Assigned To: derick
New Comment:
This is not okay, PHP should not change the original key here.
Checking it out.
Previous Comments:
------------------------------------------------------------------------
[2001-11-07 01:56:30] lampa@fee.vutbr.cz
I don't think that FAQ solves that problem.
Look at the source code of Apache server. There
are several tests of the variable "force-response-1.0"
there. The problem is not that php code variable
is $force-response-1_0, that's OK, but the real
problem is that apache variable name in r->subprocess_env
is changed too. That's side effect and not pleasent.
------------------------------------------------------------------------
[2001-11-06 16:30:56] jeroen@php.net
This is mentioned in http://uk.php.net/manual/en/faq.html.php#AEN63677
. Impossible to find if you don't know where to find it. So changing this to a documentation
problem.
(the issue is that invalid characters in incoming variable names, like dots, are converted to
underscores. This happens with any incoming variable name, be it GET, POST, ENV, or whatever.)
Changed subject
------------------------------------------------------------------------
[2001-11-06 16:09:30] lampa@fee.vutbr.cz
Apache module mod_setenvif sets variables in
r->subprocess_env. If variable name contains character ".", then
mod_php4.c/sapi_apache_register_server_variables() will
replace it with "_". This breaks internal
variables like force-response-1.0 (php changes it to
force-response-1_0).
Solution: the key in the php_register_variable() call
should be a copy of the real key.
------------------------------------------------------------------------
Edit this bug report at http://bugs.php.net/?id=13961&edit=1
Thread (6 messages)