Re: CVS update: php3/functions

On Wed, 16 Jun 1999, Sascha Schumann wrote: > On Wed, Jun 16, 1999 at 01:33:59PM +0200, Stig Bakken wrote: > > > > This has always caused some confusion, perhaps we should try cleaning it > > up? It has worked until now, either because compilers are forgiving about > > "#if FOO" when FOO is not defined, because the tests returned the same > > results on all platforms PHP is commonly used on or because those who have > > had problems did not report them. > > > > What about this: > > > > We rename all the macros that tell whether an extension should be included > > to WITH_FOO instead of HAVE_FOO, and reserve HAVE_FOO exclusively for > > macros that are either undefined or 1, like autoconf-defined ones. Then > > it'll be easier for people to know when to do what. > > > > - Stig > > Smells like trouble, if you want to convert all existing code. We > should define a policy for this, so module authors can do the > right thing for new modules and adapt old modules as well, if > they feel the need to do that. > > Your proposal sounds rational. I just commited fixes for all the undef/0 issues in config.w32.h. That probably covers most of the part where things may screw up. The rest can probably be handled by module authors like you suggest. - Stig