Re: 10% speedup patch in zend_hash_copy

From:	Andi Gutmans	Date:	Sun, 25 Nov 2001 21:01:27 +0000
Subject:	Re: 10% speedup patch in zend_hash_copy
References:	1	Groups:	php.dev
Request:	Send a blank email to php-dev+get-71604@lists.php.net to get a copy of this message

It doesn't look like such a good idea to me. There are lots of things in PHP where you can get 10% speedup by copy&pasting stuff from one function to another. It makes the code completely unmaintainable and in real life situation usually, if at all, gives a negligible speedup. I've played around a lot with this kind of stuff and it is only worth it IMO if you can really prove it makes a difference. Also, note that results may very quite considerably from platform to platform. BTW, if you can prove it really makes a difference then the solution might be inlining those functions into hash_copy() and not going in the direction of unmaintainable code. But that is a big "if" anyway as I mentioned earlier. Andi At 05:29 PM 11/25/2001 +0100, Thies C. Arntzen wrote:

    hi -

    this litte patch makes zend_hash_copy around 10% faster by
    taking a "shortcut"

    zeev, andi -
    is this "commitable" or do you have any objections?

tc