Re: Re: Sessions: garbage collection run

Yasuo Ohgaki wrote:

Ulf Wendel wrote:

Yasuo Ohgaki wrote:

Ulf Wendel wrote:

Hi, being not a php source code guru I need some help on understanding the source. Why does the session module run the garbage collection from the PHP_RINIT_FUNCTION() means from php_session_start()? Does the user notice a delay caused by PHP_RSHUTDOWN_FUNCTION()? If not what's the reason not placing the GC there.

I think Sascha wants to delete garbages before reading data and I can understand the reasons.

I asked Sascha on IRC #php.de and his answer was "Good question. It might have todo with the lifetime of PS(mod_data)." If so, it's clear.

Some users need current behavior. i.e. User want make to do gc everytime before access. User may have complex gc code to meet their needs that requires gc at module init. I vote 0 for this change.

It seems the execution order of mod_* funcions are open read gc write close So moving gc to shutdown function sounds really nice. BTW, if you use postgresql module in CVS. GC will finish ("return" to be exact) immediately, since I added async query function. I thought you may be interested. -- Yasuo Ohgaki