_php3_mktime
| From: | Cole Tuininga | Date: | Tue, 22 Jun 1999 15:04:30 +0000 |
| Subject: | _php3_mktime | ||
| Groups: | php.dev | ||
| Request: | Send a blank email to php-dev+get-7428@lists.php.net to get a copy of this message | ||
I was taking a look at the new _php3_mktime code and had a question or
two.
a) The following code segment confuses me:
if (gm)
ta.tm_isdst = 0;
else
ta.tm_isdst = -1;
if (arg_count > 6)
ta.tm_isdst = arguments[6]->value.lval;
This, to me, seems to say that if they don't specify the daylight
savings time effect for the time stamp in question, that it will
automatically assume they are in -1 mode? Instead, shouldn't we grab an
actual timestamp at this point and let the system determine the isdst?
b) We're making the assumption that a negative value for tm_min and
tm_hour are ok. Is this safe on all platforms? The only platform I
currently have access to is Linux, and it does work there...
--
I think animal testing is a terrible idea; they get all nervous and
give silly answers.
Cole Tuininga
Network Admin
Trade Services, Inc
Egon@tradeservices.com
(603) 427-1100