Bug #14671: cyrus module does not compile at all?

From: hps@intermeta.de Operating system: RedHat Linux 6.2 PHP version: 4.1.0 PHP Bug Type: Compile Failure Bug description: cyrus module does not compile at all? I'm using cyrus-imapd 2.0.16 for E-Mail. I wanted to compile the cyrus support into php for accessing the cyrus server administartion. Compilation fails with various errors. Reason for this is simple: The name of one constant is wrong, there is a superflous _ in a constant registration and finally a void function is used in an if(). This module has never compiled (or even tested) by anyone of the PHP team. Unfortunately, fixing this bug changes the name of one registered constant in php. So a doc change may be needed, too. Patch to compile the cyrus module is attached --- php-4.1.0/ext/cyrus/cyrus.c Fri Oct 12 01:51:14 2001 +++ php-4.1.0.p/ext/cyrus/cyrus.c Sun Dec 23 14:36:22 2001 @@ -85,9 +85,9 @@ le_cyrus = zend_register_list_destructors_ex(cyrus_free, NULL, le_cyrus_name, module_number); - REGISTER_LONG_CONSTANT("CYRUS_CONN_NOSYNCLITERAL", - IMCLIENT_CONN_NOSYNCLITERAL, - CONST_CS_ | CONST_PERSISTENT); + REGISTER_LONG_CONSTANT("CYRUS_CONN_NONSYNCLITERAL", + IMCLIENT_CONN_NONSYNCLITERAL, + CONST_CS | CONST_PERSISTENT); REGISTER_LONG_CONSTANT("CYRUS_CONN_INITIALRESPONSE", IMCLIENT_CONN_INITIALRESPONSE, CONST_CS | CONST_PERSISTENT); @@ -464,8 +464,7 @@ ZEND_FETCH_RESOURCE(conn, php_cyrus *, z_conn, -1, le_cyrus_name, le_cyrus); convert_to_string_ex(query); - if (imclient_send(conn->client, NULL, NULL, Z_STRVAL_PP(query)) != 0) - RETURN_FALSE; + imclient_send(conn->client, NULL, NULL, Z_STRVAL_PP(query)); -- Edit bug report at: http://bugs.php.net/?id=14671&edit=1