Re: Re: cvs: php4 /main rfc1867.c

On December 25, 2001 04:34 pm, Yasuo Ohgaki wrote: > Sterling Hughes wrote: > >>>Sterling: Thursday, December 13, 2001 7:19 PM > >>> > >>> Please provide a more descriptive note about what you changed > >>> and what was wrong. Also, it would be great if you could add > >>> some test cases, which show what the problem was, and how your > >>> fixes made the problem go away. > >> > >>Next time i will follow your advise. I did not want to write > >> redundant comments. > >>Array uploads did not work because php_register_variable truncates > >> [*] from the variable name and therefore had to be moved a few > >> lines down. I marked that as comment in the patch. And one cannot > >> really write test cases for the bugs > >>i fixed without writing something that send malformed/untypical > >> POST headers. > > > > Hrrm, yeah, I'm thinking that the test suite should contain a > > simple webserver which we can run PHP with (as a CGI even), it > > would make the test suite more robust as there are a lot of > > features that rely on the presence of a webserver... (we might > > also provide an FTP server, that doesn't need to run PHP, just to > > test certain request based services..) > > > > -Sterling > > This is one of feature for test suite that we should have ;) > > We may be better to use Apache, since web server is complex > enough to develop from scratch. > Since Apache is configurable as user want, how about include > configure line for test suite and httpd.conf? What about something like thttpd instead? Small (120k) enough to include in the testing suite and a bit less daunting to customize. :) -- Zak Greant PHP Quality Assurance Team http://qa.php.net/ "We must be the change we wish to see." - M. K. Ghandi