Re: Please check this one for math.c -Protos/ BUG or FEATURES?
| From: | Egon Schmid | Date: | Wed, 16 Jan 2002 08:24:32 +0000 |
| Subject: | Re: Please check this one for math.c -Protos/ BUG or FEATURES? | ||
| References: | 1 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-77218@lists.php.net to get a copy of this message | ||
From: "Wolfgang Drews" <drews@php.net>
> tonight i read some math.c-source, and stumbled over some things,
> that appeared a little strange to me. Please have a look at the
> following list. If you are the opinion, that i should make a bug-
> report for this ones, i will do. If you can fix it without a
report,
> i will be even more happy (will save my time :))I have tested the
> described behavior on a redhat 7.1 with php-4.2.0 dev.
>
> - PROTO-change:abs():
> -- /* {{{ proto int abs(int number)
> ++ /* {{{ proto mixed abs(mixed number)
There have been a discussion which return type is correct. IMHO it
should be the main return type. But for abs() mixed is correct,
because you can calculate abs from int and floats.
There should be more explanations in CODING_STANDARDS.
-Egon