Bug #14698 Updated: pg_fetch_array() does not require row param

ID: 14698 Updated by: yohgaki Reported By: junk-php@aontic.com Old Status: Assigned Status: Closed Bug Type: Documentation problem Operating System: Linux PHP Version: 4.1.0 Assigned To: yohgaki New Comment: Note added to doc. Previous Comments: ------------------------------------------------------------------------ [2001-12-27 05:58:34] sander@php.net Status -> assigned ------------------------------------------------------------------------ [2001-12-26 02:31:01] junk-php@aontic.com Sounds good. I think it would be silly to drop this change. - It does not appear to impact existing code (patch switches based on argument count) - The reason I discovered it because I was annoyed with what I thought the existing behavior was. Good luck with the new maintainership. ------------------------------------------------------------------------ [2001-12-26 02:26:39] yohgaki@php.net Thanks for checking the change :) I'm the new module maintainer, so I'm asking previous module maintainers about it. Since MySQL seems it does the same, I'll keep this behavior probably, but it is not a promise yet. ;) ------------------------------------------------------------------------ [2001-12-26 02:19:28] junk-php@aontic.com Implemented 6 months ago by jon (1.112) pgsql.c. Looks reasonable. ------------------------------------------------------------------------ [2001-12-26 02:13:51] junk-php@aontic.com Works wonderfully without the row. That's certainly a win convienence wise, especially for folks coming over from mysql where the loop syntax is trivial (while $row = fetch()) {} I'd prefer to see the docs change then the functionality. I'll take a look at the code itself but it is hard to see how this is a performance loss, most users end up keeping a counter anyways. Why do you prefer making the row required? It seems like a silly added restriction, especially when I bet 80% of the cases where the function is called don't need it. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/?id=14698 Edit this bug report at http://bugs.php.net/?id=14698&edit=1