Re: Re: cvs: php4(PHP_4_0_7) /sapi/roxen roxen.c

I finally figured out that my commit log is bad. Sorry guys ;) I should have mentioned it fixes build error according to bug reports and user who submitted this patch. Anyway, we are better to release 4.1.2 if we follow "release often, release early" rule. IMHO. -- Yasuo Ohgaki James Cox wrote:

-----Original Message----- From: Yasuo Ohgaki [mailto:yasuo_ohgaki@yahoo.com] Sent: Sunday, February 03, 2002 1:43 AM To: php-dev@lists.php.net; derick@php.net Subject: [PHP-DEV] Re: [PHP-CVS] cvs: php4(PHP_4_0_7) /sapi/roxen roxen.c derick@php.net wrote:

Hello, Why are you merging this? This absolutely makes no sense, 1) this branch is proably not used anymore in the future, 2) It's not anyware near a critical thing. Please revert it.

It may not be a ciritical bug for users other than Roxen. Why do you care, if this branch is not going to be used? There are many patches applied after 4.1.1 release also, if you want keep branch clean.

Yasuo, I don't see the need here to MFH a patch to 4.1.1 -- unless something _really_ major needs fixing, (and it doesn't) this branch is as good as dead.. If someone is using roxen, then we can stick a diff on the website, as a minor patch, and / or they can cvs co from HEAD. my 2 <insert currency here>