Re: [PATCH] session module

Yasuo Ohgaki wrote: > Hi all, > > If you have comments, please feedback before I apply > this patch. > > Attached patch fixes many problems in session module. > It also breaks some of script which barely worked before. > > This patch fixes: > - Crashes are caused by invlaid save_path, invalid > session id name, return value from user defined session function. > There may be other crashes observed that I don't know. > - Broken mm save handler. mm also stopped crashing under *very* highload. > - Sticky session module name To be correct, "sticky session save hanlder module" problem with session_module_name(). > - Change error level for failure to open session. > (E_ERROR -> E_WARNING) > - Dead lock with files handler > - Prevent calling session_name() and session_set_cookie_parameter() > once session is started. It doesn't work after session is started, > anyways. > - Prevent to set module name after session is started. (This causes > dead lock with files hadler. It may do something bad for other save > handlers also. It should be prevented, IMO.) > > The last fix will break some scripts. A little more additions. - Fix bogus error message with external serializer. - Prevent and raise E_NOTICE errors for function calls that not make sense for current session status. (Setting session id after session is started, etc) - Added error status to PS(session_status). It became define instead of enum to do bitwise operation. - Changed E_WARNING to E_NOTICE if function retuns error status Most of bugs except bugs related register_globals will be fixed. I appreciate if you could test it with register_globals=On. -- Yasuo Ohgaki