RE: [PHP-CVS] cvs: php4 /ext/ftp ftp.c ftp.h

Hi Stig (and others, Wez for instance), The patch below seems to have broken the ftp_get function (I used ftp_get($conn_id, $local_file, $remote_file, FTP_BINARY)) in Win95 and Win98, it now displays a warning: Warning: Type set to I. in .... on line .... and returns false. It works OK on WinNT and Win2000. The code for php_connect_nonb (contributed by Wez) mentions something about not being sure on Win32 platforms... Could you look into this please? Thanks, Marc Boeren > venaas Sun Jan 6 18:10:54 2002 EDT > > Modified files: > /php4/ext/ftp ftp.c ftp.h > Log: > Added IPv6 support > @- Added IPv6 support in FTP extension. (Stig Venaas) > > > >>>Mc>>> Snippet of the patch: this is in the ftp_getdata function <<< /* connect */ - if (my_connect(ftp, fd, (struct sockaddr*) &ftp->pasvaddr, - sizeof(ftp->pasvaddr)) == -1) - { + tv.tv_sec = ftp->timeout_sec; + tv.tv_usec = 0; + if (php_connect_nonb(fd, (struct sockaddr*) &ftp->pasvaddr, size, &tv) == -1) { perror("connect"); - closesocket(fd); - free(data); - return NULL; + goto bail; }