Re: Re: cvs: php4 / php.ini-dist php.ini-recommended /ext/tokenizer
| From: | Markus Fischer | Date: | Sat, 09 Feb 2002 09:05:37 +0000 |
| Subject: | Re: Re: cvs: php4 / php.ini-dist php.ini-recommended /ext/tokenizer | ||
| References: | 1 2 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-79797@lists.php.net to get a copy of this message | ||
On Sat, Feb 09, 2002 at 08:00:28AM +0100, Sebastian Bergmann wrote :
> Sebastian Bergmann wrote:
> > tokenizer.c
> > C:\home\php\php4\ext\tokenizer\tokenizer.c(328): error C2198:
> > 'lex_scan': Not enough parameters
> > C:\home\php\php4\ext\tokenizer\tokenizer.c(344): error C2065:
> > 'tsrm_ls': Undeclared identifier
> > C:\home\php\php4\ext\tokenizer\tokenizer.c(483): error C2198:
> > 'zend_save_lexical_state': Not enough parameters
> > C:\home\php\php4\ext\tokenizer\tokenizer.c(485): error C2198:
> > 'zend_prepare_string_for_scanning': Not enough parameters
> > C:\home\php\php4\ext\tokenizer\tokenizer.c(491): error C2198:
> > 'zend_restore_lexical_state': Not enough parameters
>
> The patch below leaves only one error and one warning:
>
> C:\home\php\php4\ext\tokenizer\tokenizer.c(328): error C2065:
> 'tsrm_ls': Undeclared identifier
>
> Adding a TSRMLS_FETCH() call doesn't cure this :-(
>
> C:\home\php\php4\ext\tokenizer\tokenizer.c(328): warning C4022:
> 'lex_scan': Incorrect pointer type for parameter 2
You don't need (and shouldn't) call TSRMLS_FETCH() here.
Declaring tokenizer() having a TSRMLS_DC and passing
TSRMLS_CC when calling it should be sufficient.
- Markus
--
Please always Cc to me when replying to me on the lists.
GnuPG Key: http://guru.josefine.at/~mfischer/C2272BD0.asc