RE: [PHP-DEV] [patch] domxml ./. trivial cleanup

The maintainer seems to be AWOL. I've never heard from him anyway. I'll commit the change though if there are no objections. It seems like instead of an assumption that found will always be !NULL, we should assert that it be !NULL. > -----Original Message----- > From: Lukas Schroeder [mailto:lukas@edeal.de] > Sent: Thursday, March 07, 2002 3:39 PM > To: php-dev@lists.php.net > Subject: [PHP-DEV] [patch] domxml ./. trivial cleanup > > > hi! > > the patch below is against cvs as of several minutes ago... > > doing > if (! found) > *found = ...; > > i did not change it into "if (found)" either, b/c found is a > non-optional parameter of internally used functions; it will not be > NULL ever. > > > > regards, > -lukas > > PS: is there currently a maintainer of the domxml code who should > be CC'd ? > > > > Index: php_domxml.c > =================================================================== > RCS file: /repository/php4/ext/domxml/php_domxml.c,v > retrieving revision 1.119 > diff -u -r1.119 php_domxml.c > --- php_domxml.c 7 Mar 2002 16:34:13 -0000 1.119 > +++ php_domxml.c 7 Mar 2002 20:29:09 -0000 > @@ -718,9 +718,7 @@ > { > zval *wrapper; > > - if (! found) { > - *found = 0; > - } > + *found = 0; > > if (!obj) { > MAKE_STD_ZVAL(wrapper); > @@ -825,9 +823,7 @@ > zval *wrapper; > int rsrc_type; > > - if (! found) { > - *found = 0; > - } > + *found = 0; > > if (!obj) { > MAKE_STD_ZVAL(wrapper); > @@ -911,9 +907,7 @@ > char *content; > int rsrc_type; > > - if (! found) { > - *found = 0; > - } > + *found = 0; > > if (!obj) { > MAKE_STD_ZVAL(wrapper); > @@ -3355,9 +3349,7 @@ > zval *wrapper; > int rsrc_type; > > - if (! found) { > - *found = 0; > - } > + *found = 0; > > if (!obj) { > MAKE_STD_ZVAL(wrapper); > > > > -- > PHP Development Mailing List <http://www.php.net/> > To unsubscribe, visit: http://www.php.net/unsub.php