Re: Including bandled expat.h

From: Date: Mon, 11 Mar 2002 08:39:54 +0000
Subject: Re: Including bandled expat.h
References: 1 2  Groups: php.dev 
Request: Send a blank email to php-dev+get-81002@lists.php.net to get a copy of this message
derick@php.net wrote:
On Mon, 11 Mar 2002, Yasuo Ohgaki wrote:
Any reason not to including bandled expat.h explicitly? Any comments for possible fix?
The bundled file may differ from the used library, so this is not a good idea.
I agree. There is with-expat-dir option also :) Build system should be fixed, then. PHP cannot find bandled header now. (can find lib) [yohgaki@dev DEV]$ LANG=C make /bin/sh /home/yohgaki/cvs/php/DEV/libtool --mode=compile gcc -DSUPPORT_UTF8 -I/home/yohgaki/cvs/php/DEV/ext/pcre/pcrelib -I/home/yohgaki/cvs/php/DEV/ext/wddx -I/home/yohgaki/cvs/php/DEV/ext/wddx -I/home/yohgaki/cvs/php/DEV/main -I/home/yohgaki/cvs/php/DEV -I/usr/include/apache -I/home/yohgaki/cvs/php/DEV/Zend -I/usr/local/include -I/usr/include/libxml2 -I/usr/include/freetype2/freetype -I/usr/local/pgsql/include -I/usr/include/ucd-snmp -DLINUX=22 -DMOD_SSL=208106 -DUSE_HSREGEX -DEAPI -DUSE_EXPAT -I/home/yohgaki/cvs/php/DEV/TSRM -g -Wall -prefer-pic -c /home/yohgaki/cvs/php/DEV/ext/wddx/wddx.c -o ext/wddx/wddx.lo gcc -DSUPPORT_UTF8 -I/home/yohgaki/cvs/php/DEV/ext/pcre/pcrelib -I/home/yohgaki/cvs/php/DEV/ext/wddx -I/home/yohgaki/cvs/php/DEV/ext/wddx -I/home/yohgaki/cvs/php/DEV/main -I/home/yohgaki/cvs/php/DEV -I/usr/include/apache -I/home/yohgaki/cvs/php/DEV/Zend -I/usr/local/include -I/usr/include/libxml2 -I/usr/include/freetype2/freetype -I/usr/local/pgsql/include -I/usr/include/ucd-snmp -DLINUX=22 -DMOD_SSL=208106 -DUSE_HSREGEX -DEAPI -DUSE_EXPAT -I/home/yohgaki/cvs/php/DEV/TSRM -g -Wall -c /home/yohgaki/cvs/php/DEV/ext/wddx/wddx.c -fPIC -DPIC -o ext/wddx/wddx.lo In file included from /home/yohgaki/cvs/php/DEV/ext/wddx/wddx.c:22: /home/yohgaki/cvs/php/DEV/ext/wddx/php_wddx.h:26:19: expat.h: No such file or directory In file included from /home/yohgaki/cvs/php/DEV/ext/wddx/wddx.c:28: /home/yohgaki/cvs/php/DEV/ext/xml/php_xml.h:38:19: expat.h: No such file or directory make: *** [ext/wddx/wddx.lo] Error 1 [yohgaki@dev DEV]$ -- Yasuo Ohgaki
Derick
Index: ext/wddx/php_wddx.h =================================================================== RCS file: /repository/php4/ext/wddx/php_wddx.h,v retrieving revision 1.10 diff -u -r1.10 php_wddx.h --- ext/wddx/php_wddx.h 28 Feb 2002 08:26:56 -0000 1.10 +++ ext/wddx/php_wddx.h 11 Mar 2002 07:02:18 -0000 @@ -23,7 +23,7 @@ #if HAVE_WDDX -#include <expat.h> +#include "ext/xml/expat/expat.h" extern zend_module_entry wddx_module_entry; #define wddx_module_ptr &wddx_module_entry Index: ext/xml/php_xml.h =================================================================== RCS file: /repository/php4/ext/xml/php_xml.h,v retrieving revision 1.19 diff -u -r1.19 php_xml.h --- ext/xml/php_xml.h 11 Dec 2001 15:30:51 -0000 1.19 +++ ext/xml/php_xml.h 11 Mar 2002 07:02:18 -0000 @@ -35,7 +35,7 @@ #if defined(PHP_XML_INTERNAL) -#include <expat.h> +#include "ext/xml/expat/expat.h" #ifdef PHP_WIN32 #define PHP_XML_API __declspec(dllexport) -- Yasuo Ohgaki -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php
----------------------------------------------------------------------
              PHP: Scripting the Web - derick@php.net
                All your branches are belong to me!
            SRM: Site Resource Manager - www.vl-srm.net
-----------------------------------------------------------------------
-- Yasuo Ohgaki yohgaki@dd.iij4u.or.jp

« previous php.dev (#81002) next »