Re: cvs: php4 /ext/pgsql pgsql.c
| From: | Yasuo Ohgaki | Date: | Tue, 12 Mar 2002 03:04:16 +0000 |
| Subject: | Re: cvs: php4 /ext/pgsql pgsql.c | ||
| References: | 1 | Groups: | php.cvs php.dev |
| Request: | Send a blank email to php-dev+get-81048@lists.php.net to get a copy of this message | ||
Yasuo Ohgaki wrote:
yohgaki Mon Mar 11 09:53:59 2002 EDTHi all, Currently pgsql module's error message is not consistent with other modules' error message format and does not print function names. I would like to fix that as follows. (This is only one of them, but there are many error messages like this) If you have opinion, please let me know.Modified files: /php4/ext/pgsql pgsql.c Log:Print function names in error messages
Index: php4/ext/pgsql/pgsql.c diff -u php4/ext/pgsql/pgsql.c:1.153 php4/ext/pgsql/pgsql.c:1.154 --- php4/ext/pgsql/pgsql.c:1.153 Mon Mar 11 02:23:07 2002 +++ php4/ext/pgsql/pgsql.c Mon Mar 11 09:53:59 2002 @@ -19,7 +19,7 @@-- Yasuo Ohgaki yohgaki@dd.iij4u.or.jp+----------------------------------------------------------------------+*/ -/* $Id: pgsql.c,v 1.153 2002/03/11 07:23:07 yohgaki Exp $ */ +/* $Id: pgsql.c,v 1.154 2002/03/11 14:53:59 yohgaki Exp $ */ #include <stdlib.h> @@ -1029,7 +1029,8 @@ convert_to_long_ex(field); if (Z_LVAL_PP(field) < 0 || Z_LVAL_PP(field) >= PQnfields(pgsql_result)) { - php_error(E_WARNING,"Bad field offset specified"); + php_error(E_WARNING,"%s() bad field offset specified", + get_active_function_name(TSRMLS_C)); RETURN_FALSE; }