Re: Re: cvs: php4 /main php.h

derick@php.net wrote:

On Fri, 15 Mar 2002, Yasuo Ohgaki wrote:

According to Derick's post, VC defines NDEBUG somewhere else. Following patch should fix "redfined" warnings.

This doesn't seem like a good idea, VC++ might be using NDEBUG for very different reasons. How did you come up with the name NDEBUG?

Accoding to ISO9899(ANSI C) standard, NDEBUG is used for assert.h. VC may define/use it some other reasons? I just don't have any idea.

Do I need "#define assert(expr) ASSERT(expr)" also for VC?

I've no idea, sebastian?

I hope someone confirm how it should be treated under VC. -- Yasuo Ohgaki

Derick

--- php.h.~1.161.~ Fri Mar 15 15:36:56 2002 +++ php.h Fri Mar 15 18:47:43 2002 @@ -63,18 +63,18 @@ #include "php_regex.h" -#ifndef PHP_WIN32 #if HAVE_ASSERT_H #if PHP_DEBUG #undef NDEBUG #else +#ifndef NDEBUG #define NDEBUG +#endif /* NDEBUG */ #endif #include <assert.h> #else /* HAVE_ASSERT_H */ #define assert(expr) ((void) (0)) #endif /* HAVE_ASSERT_H */ -#endif /* PHP_WIN32 */ #define APACHE 0 -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

-----------------------------------------------------------------------

              PHP: Scripting the Web - derick@php.net
                All your branches are belong to me!
            SRM: Site Resource Manager - www.vl-srm.net

-----------------------------------------------------------------------